Fix false positives for defineModel in vue/no-undef-properties ru…

…le (#2364)
vuejs · Jan 13, 2024 · ad2ffda · ad2ffda
1 parent af7de76
commit ad2ffda
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 15 deletions.
diff --git a/lib/rules/no-undef-properties.js b/lib/rules/no-undef-properties.js
@@ -322,25 +322,12 @@ module.exports = {
             propertyReferenceExtractor.extractFromPattern(pattern)
           ctx.verifyReferences(propertyReferences)
         },
-        onDefineModelEnter(node, model) {
+        onDefineModelEnter(_node, model) {
           const ctx = getVueComponentContext(programNode)
 
           ctx.defineProperties.set(model.name.modelName, {
             isProps: true
           })
-
-          if (
-            !node.parent ||
-            node.parent.type !== 'VariableDeclarator' ||
-            node.parent.init !== node
-          ) {
-            return
-          }
-
-          const pattern = node.parent.id
-          const propertyReferences =
-            propertyReferenceExtractor.extractFromPattern(pattern)
-          ctx.verifyReferences(propertyReferences)
         }
       }),
       utils.defineVueVisitor(context, {

diff --git a/tests/lib/rules/no-undef-properties.js b/tests/lib/rules/no-undef-properties.js
@@ -558,7 +558,16 @@ tester.run('no-undef-properties', rule, {
       parserOptions: {
         parser: require.resolve('@typescript-eslint/parser')
       }
-    }
+    },
+
+    `
+    <script setup>
+    const model = defineModel();
+    const woof = computed(() => model.value);
+    </script>
+    <template>
+      <div id="app">Woof: {{ woof }}</div>
+    </template>`
   ],
 
   invalid: [