Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off require-v-for-key by default. #1042

Closed
wants to merge 1 commit into from
Closed

Conversation

Timmmm
Copy link

@Timmmm Timmmm commented Jan 30, 2020

This lint is too restrictive, and isn't able to detect the cases when it is wrong.

See vuejs/vetur#261

This lint is too restrictive, and isn't able to detect the cases when it is wrong.

See vuejs/vetur#261
@przemkow
Copy link
Contributor

@Timmmm I recently created PR to this repository and it seems that file you edited is generated automatically during npm run update command (it's generated based on the configuration in lib/rules/*.js).

PS . You can also find in eslint-plugin-vue docs developers guide which might be pretty helpful (link) 🙂

@ota-meshi
Copy link
Member

ota-meshi commented Jan 31, 2020

Hi @Timmmm. This category is based on the style guide.

https://vuejs.org/v2/style-guide/#Keyed-v-for-essential

You can change the settings freely using the ".eslintrc. *" file.

https://eslint.vuejs.org/user-guide/#usage

@ota-meshi ota-meshi closed this Jan 31, 2020
@Timmmm
Copy link
Author

Timmmm commented Feb 4, 2020

Unfortunately disabling this in .eslintrc has no effect.

@Timmmm
Copy link
Author

Timmmm commented Feb 4, 2020

Also the style guide says:

Then in the rare, performance-critical scenarios where object constancy isn’t necessary, you can make a conscious exception.

But you can't do that with this rule enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants