Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add no-deprecated-delete-set rule #2540

Merged
merged 6 commits into from
Sep 12, 2024

Conversation

waynzh
Copy link
Contributor

@waynzh waynzh commented Aug 30, 2024

resolves #2526 proposal

docs/rules/no-deprecated-delete-set.md Outdated Show resolved Hide resolved
docs/rules/no-deprecated-delete-set.md Outdated Show resolved Hide resolved
docs/rules/no-deprecated-delete-set.md Show resolved Hide resolved
lib/rules/no-deprecated-delete-set.js Outdated Show resolved Hide resolved
lib/rules/no-deprecated-delete-set.js Outdated Show resolved Hide resolved
tests/lib/rules/no-deprecated-delete-set.js Outdated Show resolved Hide resolved
@FloEdelmann FloEdelmann mentioned this pull request Aug 30, 2024
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks! 🙂

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!
I have a change request.

lib/rules/no-deprecated-delete-set.js Outdated Show resolved Hide resolved
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!!!

@ota-meshi ota-meshi merged commit dfdbe1a into vuejs:master Sep 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule Proposal: vue/no-deprecated-delete-set
3 participants