Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(babel-sugar-inject-h): setup method support #76

Closed
wants to merge 1 commit into from

Conversation

u3u
Copy link

@u3u u3u commented Aug 17, 2019

@u3u
Copy link
Author

u3u commented Aug 22, 2019

@sodatea Do you have any thoughts?

@haoqunjiang
Copy link
Member

I don't think this repository is the best place to provide this utility.
vue-function-api is an experimental plugin. Its API is still subject to change as the discussion of the RFC moves along. So I recommend you to ship a standalone babel plugin for setup support, and then point to that package in the vue-function-api repository for those who do need it.

@u3u
Copy link
Author

u3u commented Aug 22, 2019

Well, but can not get this in the setup method, so will cause an exception. Should I skip it?

@luwanquan
Copy link
Contributor

I wrote a babel plugin to solve this problem, see babel-preset-vca-jsx.

@haoqunjiang
Copy link
Member

As @vue/composition-api is preparing for a v1 release (vuejs/composition-api#390), I think now is a good time to have first-class support for this usage.

If anyone's interested, would you please open a new PR based on the latest version of @vue/composition-api?
I would love to do this myself but I haven't got the time, so any help is appreciated.

Cc: @antfu

@haoqunjiang
Copy link
Member

Closing as #142 has been merged and released in v1.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants