Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-core): local name support for prop using runtime api #4650

Merged
merged 11 commits into from
Aug 25, 2024

Conversation

KazariEX
Copy link
Collaborator

@KazariEX KazariEX commented Aug 5, 2024

fix #4649

@KazariEX
Copy link
Collaborator Author

KazariEX commented Aug 5, 2024

I need some help. I've built the correct virtual code, however, as long as the local variable is named different from the prop name, the type will be inferred as any. Did I miss anything else that needs attention?

@KazariEX KazariEX changed the title fix(language-core): local name support for defineModel using runtime api fix(language-core): local name support for prop using runtime api Aug 5, 2024
@KazariEX KazariEX marked this pull request as ready for review August 6, 2024 11:39
Copy link

pkg-pr-new bot commented Aug 25, 2024

commit: fc86682

vue-component-meta

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-meta@4650

vue-component-type-helpers

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@4650

@vue/language-core

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-core@4650

@vue/language-plugin-pug

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@4650

@vue/language-server

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-server@4650

@vue/language-service

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-service@4650

vue-tsc

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-tsc@4650

@vue/typescript-plugin

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@4650

Open in Stackblitz

@johnsoncodehk
Copy link
Member

LGTM, thanks!

@johnsoncodehk johnsoncodehk merged commit 6bb7820 into vuejs:master Aug 25, 2024
5 checks passed
@KazariEX KazariEX deleted the fix/issue-4649 branch August 26, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type check error when using local name different from prop name with runtime api
2 participants