Multi root support #424

octref · 2017-09-11T18:30:25Z

Explore support for VSCode's new Multi-root workspace feature.
Notably, rootPath now can be a list.

https://github.com/Microsoft/vscode/wiki/Extension-Authoring:-Adopting-Multi-Root-Workspace-APIs

This is somewhat different from #385, depending on the way the user uses VSCode.
For the following app,

/app
  /client
  /server
  /doc

One might open /app in one Window. Vetur support for /client is Support sub folders and multiple tsconfig files in one window #385.
One might open /app/client, /app/server as two top-level folders. That's this issue.
One might open two Vue apps as two top-level folders. That's this issue.

IssueHunt Summary

Backers (Total: $250.00)

mesqueeb ($10.00)
garyo ($10.00)
tobspr ($100.00)
$130.00 have been anonymously funded.

Become a backer now!

Or submit a pull request to get the deposits!

Tips

Checkout the Issuehunt explorer to discover more funded issues.
Need some help from other developers? Add your repositories on IssueHunt to raise funds.

The text was updated successfully, but these errors were encountered:

alexsasharegan · 2018-02-28T02:15:02Z

If you need any testing, I have a use case explained here: #423 (comment). I'll be happy to test any progress on this feature.

evenfrost · 2018-04-25T11:32:32Z

One workaround could be found here: #423 (comment).

brandonson · 2018-10-22T21:50:03Z

I had issues where this and vscode-jest both wanted to be the first (root) folder. Fixed things to some extent - quick and dirty fix adding multi-root support for Vetur lives here: https://github.com/brandonson/vetur

Clone to your extensions dir and follow setup from Vetur's CONTRIBUTING.md. After the compile step you should be good to go.

It is, as mentioned, a quick dirty fix that iterates through the workspace folders looking for a package.json with vue as a dependency. It won't work for newly added folders (you'll need to restart vscode) and it won't handle the case of two vue workspaces. I'll probably try to clean it up and maybe get to a PR eventually, but time constraints mean that's not at the top of my list right this moment - that, and I don't know how this should interact with the centralization from #800.

Edit to add: See the basic-multiroot branch. Master contains the early hack, basic-multiroot is much better.

RobertWHurst · 2019-12-12T06:14:39Z

Any action on this? It's been more than a year and this is still broken.

rtbo · 2020-01-01T11:49:47Z

I have a monorepo project with one of the packages being a vue client project with vuetify dependency.
I'm using yarn workspaces.
The structure is like so:

<root>
├── node_modules
│   ├── vue
│   ├── vue-apollo
│   ├── vue-router
│   ├── vuetify
│   ├── vuex
│   ├── [...]
├── package.json
├── packages
│   ├── my-vue-app
│   │   ├── babel.config.js
│   │   ├── node_modules
│   │   │   └── [ nearly empty folder thanks to yarn workspaces ]
│   │   ├── package.json
│   │   ├── public
│   │   ├── src
│   │   ├── [...]
│   ├── [other packages]
└── [...]

If I run VSCode from <root>/packages/my-vue-app, I don't have template intellisense finding vuetify tags/attributes.
I believe this has to do with vuetify being under <root>/node_modules instead of my-vue-app/node_modules.
However If I add a few dependencies under <root>/package.json (which normally has none) and run VSCode from <root>, then template intellisense finally works!
<root>/package.json:

    "dependencies": {
        "vue": "^2.6.10",
        "vue-apollo": "^3.0.2",
        "vue-router": "^3.1.3",
        "vuetify": "^2.1.10",
        "vuex": "^3.0.1"
    },

This doesn't seem to have side effects for me at the moment.
An easy fix would be to extend the dependency search in parent folders if a dependency is not found under ${workspaceRoot}/node_modules. Unless the dependencies are not installed yet, all dependencies should eventually be found that way.

davidbludlow · 2020-05-19T18:03:20Z

This problem definitely needs a real fix.

I found a workaround that worked specifically in my case: I had a vscode workspace file like all-projects.code-workspace

{
	"folders": [
		{
			"path": "activities-backend"
		},
		{
			"path": "activities-frontend"
		},
		{
			"path": "graspable-math"
		}
	]
}

The "activities-frontend" folder had my Vue project in it, but Vetur was trying to use the tsconfig.json in my "activities-backend" folder. I fixed it by rearranging my workspace file like

{
	"folders": [
		{
			"path": "activities-frontend"
		},
		{
			"path": "activities-backend"
		},
		{
			"path": "graspable-math"
		}
	]
}

. That got rid of the inappropriate Vetur errors that looked kinda like File '~/git/activities-frontend/src/foo.ts' is not under 'rootDir' '~/git/activities-backend/src'. 'rootDir' is expected to contain all source files.

I haven't tested this with a workspace that has more than one Vue project in it, but I suspect this workaround would fail for that.

davidbludlow · 2020-05-19T18:11:31Z

A related Vetur issue https://issuehunt.io/r/vuejs/vetur/issues/815 has a bounty of $264 so far.

issuehunt-oss · 2020-06-28T02:08:21Z

@mesqueeb has funded $10.00 to this issue.

Submit pull request via IssueHunt to receive this reward.
Want to contribute? Chip in to this issue via IssueHunt.
Checkout the IssueHunt Issue Explorer to see more funded issues.
Need help from developers? Add your repository on IssueHunt to raise funds.

mesqueeb · 2020-06-28T02:11:30Z

Hi guys. I just funded $10 to this issue.

My use case:

I have a Lerna project with a bunch of Vue related projects (some just single components) inside ./packages.
I like to open the entire Lerna project in 1 window in VSCode & be able to have Vetur working correctly.

My current issue:

Vetur doesn't read the tsconfig.json of each project properly.

I hope this funding can promote others to also fund this issue and I hope to see full support for Lerna Monorepo's soon!! <3

issuehunt-oss · 2020-06-28T13:10:27Z

@garyo has funded $10.00 to this issue.

Submit pull request via IssueHunt to receive this reward.
Want to contribute? Chip in to this issue via IssueHunt.
Checkout the IssueHunt Issue Explorer to see more funded issues.
Need help from developers? Add your repository on IssueHunt to raise funds.

garyo · 2020-06-28T13:12:54Z

Same here ($10). I'm using Emacs with eglot in a Yarn workspaces monorepo where the Vue front-end project is in one of the workspaces.

bangjelkoski · 2020-07-09T13:31:47Z

This problem definitely needs a real fix.

I found a workaround that worked specifically in my case: I had a vscode workspace file like all-projects.code-workspace
{
	"folders": [
		{
			"path": "activities-backend"
		},
		{
			"path": "activities-frontend"
		},
		{
			"path": "graspable-math"
		}
	]
}
The "activities-frontend" folder had my Vue project in it, but Vetur was trying to use the tsconfig.json in my "activities-backend" folder. I fixed it by rearranging my workspace file like
{
	"folders": [
		{
			"path": "activities-frontend"
		},
		{
			"path": "activities-backend"
		},
		{
			"path": "graspable-math"
		}
	]
}
. That got rid of the inappropriate Vetur errors that looked kinda like File '~/git/activities-frontend/src/foo.ts' is not under 'rootDir' '~/git/activities-backend/src'. 'rootDir' is expected to contain all source files.

I haven't tested this with a workspace the has more than one Vue project in it, but I suspect this workaround would fail for that.

I can confirm that this solution works. Moving your vue or nuxt project on the top of the list fixes the issue.

issuehunt-oss · 2020-07-15T12:27:09Z

An anonymous user has funded $5.00 to this issue.

Submit pull request via IssueHunt to receive this reward.
Want to contribute? Chip in to this issue via IssueHunt.
Checkout the IssueHunt Issue Explorer to see more funded issues.
Need help from developers? Add your repository on IssueHunt to raise funds.

heavenkiller2018 · 2020-08-01T04:19:29Z

oh, my god! who can fix the bug?

Minigugus · 2020-08-07T21:40:32Z

#1734 seems to work with lerna projects and multi-root workspaces. Can someone give it a try?

mesqueeb · 2020-08-08T12:55:47Z

@Minigugus that would be a dream come true 😍 I hope someone can test and merge soon <3

johnsoncodehk · 2020-08-21T13:52:55Z

In case someone need, here is a transition tool that can be used before Vetur support multi root:
https://marketplace.visualstudio.com/items?itemName=johnsoncodehk.volar

vigenere23 · 2020-09-03T23:55:44Z

In case someone need, here is a transition tool that can be used before Vetur support multi root:
https://marketplace.visualstudio.com/items?itemName=johnsoncodehk.volar

Thanks for that! Works great, but it throws some linting errors that Vetur doesn't throw :/

This works around lack of multi-root support in vetur: vuejs/vetur#424 (comment)

kytosai · 2020-10-06T08:13:12Z

@octref

This problem has been going on for a long time, and there are many projects that require multi root

I have seen some PRs addressing the multi-root issue, I hope you can consider leaving it as an option to enable or disable to temporarily resolve the extension's multi rool issue until you have a good solution !

Thanks you !

issuehunt-oss · 2020-10-13T09:23:25Z

An anonymous user has funded $20.00 to this issue.

Submit pull request via IssueHunt to receive this reward.
Want to contribute? Chip in to this issue via IssueHunt.
Checkout the IssueHunt Issue Explorer to see more funded issues.
Need help from developers? Add your repository on IssueHunt to raise funds.

issuehunt-oss · 2020-10-13T21:01:46Z

@tobspr has funded $100.00 to this issue.

Submit pull request via IssueHunt to receive this reward.
Want to contribute? Chip in to this issue via IssueHunt.
Checkout the IssueHunt Issue Explorer to see more funded issues.
Need help from developers? Add your repository on IssueHunt to raise funds.

yoyo930021 · 2020-10-14T14:15:41Z

Hi everyone,
 If you interested this issue, 
you can go to #2377 and #2378.
View and post your ideas.

issuehunt-oss · 2020-10-15T12:01:34Z

An anonymous user has funded $100.00 to this issue.

Submit pull request via IssueHunt to receive this reward.
Want to contribute? Chip in to this issue via IssueHunt.
Checkout the IssueHunt Issue Explorer to see more funded issues.
Need help from developers? Add your repository on IssueHunt to raise funds.

issuehunt-oss · 2020-11-11T12:02:28Z

An anonymous user has funded $5.00 to this issue.

Submit pull request via IssueHunt to receive this reward.
Want to contribute? Chip in to this issue via IssueHunt.
Checkout the IssueHunt Issue Explorer to see more funded issues.
Need help from developers? Add your repository on IssueHunt to raise funds.

…e first vuejs/vetur#424

octref added the feature-request label Sep 11, 2017

octref self-assigned this Sep 11, 2017

kieferrm mentioned this issue Sep 11, 2017

Iteration Plan for September 2017 microsoft/vscode#34160

Closed

48 tasks

egamma mentioned this issue Oct 9, 2017

Iteration Plan for October 2017 microsoft/vscode#35875

Closed

40 tasks

octref mentioned this issue Nov 6, 2017

Formatting issues #476

Closed

HerringtonDarkholme mentioned this issue Nov 19, 2017

Support tsconfig.json in the subdirectory. #553

Closed

3 tasks

octref mentioned this issue Dec 5, 2017

Support sub folders and multiple tsconfig files in one window #385

Closed

2 tasks

HerringtonDarkholme mentioned this issue Dec 24, 2017

Could not works well with projects in workspace #602

Closed

3 tasks

HerringtonDarkholme mentioned this issue Feb 28, 2018

Can fix Intellisense and go to definition for absolute path #423

Closed

octref mentioned this issue Mar 6, 2018

Vetur ignoring tsconfig.json from project when running VSCode in workspace mode #687

Closed

3 tasks

octref mentioned this issue May 21, 2018

Centralize all file system access in VLS #800

Closed

TheAkio mentioned this issue May 23, 2018

experimentalDecorators: true in tsconfig.json is not working #567

Closed

3 tasks

ryanjaeb mentioned this issue Jul 10, 2018

Pick up tsconfig from non-top-level folder #815

Closed

3 tasks

octref mentioned this issue Aug 13, 2018

Vetur 1.0 Roadmap #873

Open

17 tasks

octref mentioned this issue Apr 26, 2019

vetur script validation error: cannot find module, but can use this module, no problem #1017

Open

octref mentioned this issue Nov 6, 2019

Default FAQ js(ts)config for webpack aliases doesn't work. #890

Closed

3 tasks

doman412 mentioned this issue Apr 16, 2020

Vetur doesn't detect augmentation of Vue when using typescript #1817

Closed

3 tasks

DarkLite1 mentioned this issue May 11, 2020

Cannot find module xxx #1896

Closed

3 tasks

vojvodics mentioned this issue May 24, 2020

Add support for multi-root workspace #1928

Closed

This was referenced Jun 3, 2020

Fails to respect tsconfig when in a Workspace #1920

Closed

IntelliSense not working for context.root.$router in the Vue compositionAPI #1926

Closed

issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label Jun 28, 2020

yoyo930021 mentioned this issue Jul 21, 2020

Cannot find module 'xxxx' when using path mapping #762

Closed

3 tasks

Minigugus mentioned this issue Aug 10, 2020

Pick up tsconfig from non-top-level folders #1734

Open

2 tasks

stanislav-suslov mentioned this issue Aug 13, 2020

Incorrect resolve of path links to @ if vue project is located in subdirectory. #1892

Closed

3 tasks

rbclark mentioned this issue Sep 3, 2020

Monorepo cleanup mitre/heimdall2#132

Merged

rbclark pushed a commit to mitre/heimdall2 that referenced this issue Sep 8, 2020

Add code-workspace for vscode

801c731

This works around lack of multi-root support in vetur: vuejs/vetur#424 (comment)

octref mentioned this issue Sep 21, 2020

Throws error about multiple root elements in template. (Vue 3 + TypeScript) #2299

Closed

krid-sdnera pushed a commit to krid-sdnera/contact-system that referenced this issue Nov 22, 2020

Fix VS Code - Vetur plugin not finding tsconfig when ui folder not th…

4bc62eb

…e first vuejs/vetur#424

yoyo930021 mentioned this issue Dec 8, 2020

Impl monorepo and vetur config file support #2495

Merged

13 tasks

yoyo930021 closed this as completed in #2495 Dec 8, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multi root support #424

Multi root support #424

octref commented Sep 11, 2017 •

edited by issuehunt-oss bot

Loading

Backers (Total: $250.00)

Become a backer now!

Or submit a pull request to get the deposits!

Tips

alexsasharegan commented Feb 28, 2018

evenfrost commented Apr 25, 2018

brandonson commented Oct 22, 2018 •

edited

Loading

RobertWHurst commented Dec 12, 2019

rtbo commented Jan 1, 2020

davidbludlow commented May 19, 2020 •

edited

Loading

davidbludlow commented May 19, 2020

issuehunt-oss bot commented Jun 28, 2020

mesqueeb commented Jun 28, 2020

issuehunt-oss bot commented Jun 28, 2020

garyo commented Jun 28, 2020

bangjelkoski commented Jul 9, 2020

issuehunt-oss bot commented Jul 15, 2020

heavenkiller2018 commented Aug 1, 2020

Minigugus commented Aug 7, 2020

mesqueeb commented Aug 8, 2020

johnsoncodehk commented Aug 21, 2020

vigenere23 commented Sep 3, 2020

kytosai commented Oct 6, 2020 •

edited

Loading

issuehunt-oss bot commented Oct 13, 2020

issuehunt-oss bot commented Oct 13, 2020

yoyo930021 commented Oct 14, 2020

issuehunt-oss bot commented Oct 15, 2020

issuehunt-oss bot commented Nov 11, 2020

Multi root support #424

Multi root support #424

Comments

octref commented Sep 11, 2017 • edited by issuehunt-oss bot Loading

Backers (Total: $250.00)

Become a backer now!

Or submit a pull request to get the deposits!

Tips

alexsasharegan commented Feb 28, 2018

evenfrost commented Apr 25, 2018

brandonson commented Oct 22, 2018 • edited Loading

RobertWHurst commented Dec 12, 2019

rtbo commented Jan 1, 2020

davidbludlow commented May 19, 2020 • edited Loading

davidbludlow commented May 19, 2020

issuehunt-oss bot commented Jun 28, 2020

mesqueeb commented Jun 28, 2020

issuehunt-oss bot commented Jun 28, 2020

garyo commented Jun 28, 2020

bangjelkoski commented Jul 9, 2020

issuehunt-oss bot commented Jul 15, 2020

heavenkiller2018 commented Aug 1, 2020

Minigugus commented Aug 7, 2020

mesqueeb commented Aug 8, 2020

johnsoncodehk commented Aug 21, 2020

vigenere23 commented Sep 3, 2020

kytosai commented Oct 6, 2020 • edited Loading

issuehunt-oss bot commented Oct 13, 2020

issuehunt-oss bot commented Oct 13, 2020

yoyo930021 commented Oct 14, 2020

issuehunt-oss bot commented Oct 15, 2020

issuehunt-oss bot commented Nov 11, 2020

octref commented Sep 11, 2017 •

edited by issuehunt-oss bot

Loading

brandonson commented Oct 22, 2018 •

edited

Loading

davidbludlow commented May 19, 2020 •

edited

Loading

kytosai commented Oct 6, 2020 •

edited

Loading