Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pre publish hook #260

Merged
merged 1 commit into from
Jun 23, 2017
Merged

Remove pre publish hook #260

merged 1 commit into from
Jun 23, 2017

Conversation

octref
Copy link
Member

@octref octref commented Jun 22, 2017

The thing is vsce publish could fail (or sometimes I'd abort it if I realize I forgot something when publishing). In that case I don't want to run sync again, especially for npm publish.
I'm ok with running two commands each time

yarn sync
vsce publish

@HerringtonDarkholme HerringtonDarkholme merged commit 924edf0 into master Jun 23, 2017
octref added a commit that referenced this pull request Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants