-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebar always showing in the home page #825
Comments
what's your sidebar configs in |
Please provide a minimal reproducible example. |
you can look my config here |
Hi, Thank you @alexzhang1030, @Loveyless the problem resolved. So I have to explicitly define routes when the sidebar should appear that make sense. if I pass directly an array the side bar always showing, but the way is to pass an object. Thank you for help. |
Hi @brc-dd I suggest that by default hide any sidebar from the layout home. |
Probably need to change this line:
to: return frontmatter.value.sidebar !== false && sidebar.value.length > 0 && frontmatter.value.layout !== 'home' |
Ah yeah, let's do that. Home layout isn't built for Sidebar in mind so the style will never work. Home layout should always hide sidebar 👍 |
thank you, @Loveyless ! |
Describe the bug
Sidebar always showing in the home page
Reproduction
I just get started
Expected behavior
Sidebar hides on home
System Info
Additional context
No response
Validations
The text was updated successfully, but these errors were encountered: