Replace the line highlighting logic with Shiki lineOptions #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The UI has certain issues:
|
Sorry I found it too. Fixed already. 🙏 |
brc-dd
approved these changes
Aug 9, 2022
|
IG we missed some UI issues here: On https://deploy-preview-1152--vitepress-docs.netlify.app/guide/using-vue.html (and current vitepress.vuejs.org too), there are padding issues:
Also, new lines in code blocks aren't being respected:
Earlier it was like this (you can use some older PR deploy like https://deploy-preview-1132--vitepress-docs.netlify.app/guide/using-vue.html to see):
|
This was referenced Aug 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-implemented line highlighting logic according to @octref's approach vuejs/theme#41
Changes:
src/node/markdown/plugins/highlightLines.ts: only normalize the line info and append it back totoken.infosrc/node/markdown/plugins/highlight.ts: parse the normalized line info intolineOptionsand pass it into shiki.src/client/theme-default/styles/components/vp-doc.css: style update accordingly to code blocksThanks.