feat: $lang and $localePath globals (#166) #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot and sorry for the late reply! Looking good 👍 👍 👍 And yes, I agree we don't need other globals which are not documented 😅 |
kiaking
changed the title
|
Hey @kiaking, don't worry 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #166
As discussed in #166
I now see that there several globals that are exposed but are not documented.
$localeConfigand$themeLocaleConfiglooks like they are parts of$siteByRoutein vitepressThere are also
$siteTitle,$canonicalUrlIn my opinion, there is no need to add any of these four globals that are not documented.