-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(theme): auto style markdown content in home page #3561
Conversation
If you're using pnpm here's a
|
/cc @kiaking This is a breaking change. If we want, we should do this before v1. Or probably instead of slot, just provide the component so the people who need to add custom markup can use it instead. |
To clarify: the end goal is to be able to do this WITHOUT MUCH CONFIG or importing any additional components. (no ---
layout: home
docsOnHomepage: true # or "extraHomeContent: true" or whatever
hero: ...
---
You can get started using $X right away! You can use npm, Yarn, pnpm, or bun to install it:
```sh
npm install $X
```
Read more in [the getting started guide](/guide/) an option could be added if this absolutely cannot be default behavior 🤷♀️ similar to how there's a |
Yeah we can go with frontmatter approach. It'll just need a v-if. |
Update so that:
IMO the default behaviour should be the one that's least surprising to users. Having good Markdown styles on the literal home page seems like something that's expected. Having it weirdly break and get shoved to the side by default is surprising. I think it should be opt-in to old behaviour instead of opt-in to new behaviour. 🤷♀️ feel free to edit this PR yourself to change the name of the option, edit the docs, or invert the logic so that it's off by default! 😊 |
We're rapidly approach the point of no return on this. It seems appropriate to have it on by default, but I agree that this is a breaking change. It's not too late to make this change, and I still feel strongly that this was a gross oversight to leave out initially but, unless this gets prioritized ASAP, we're going to rapidly approach the point that |
As it is, issue #800 if the most popular and commented-on issue ticket in this repo. |
Yeah I'll merge and release this by weekend. |
layout: home
Markdown content in a <VPHomeContent>
component
nb, level 1 headings ( |
fix #800 using #800 (comment) code