feat: support custom content in home layout #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brc-dd
reviewed
Jun 2, 2022
kiaking
approved these changes
Jun 6, 2022
There was a problem hiding this comment.
Thanks a lot! I've simplified the DOM structure and removed vp-docs style for now. Since I think usually when you want to customize Homepage, default styles might be too much to have. And it's easier to opt-in by adding vp-docs style than opt-out from it so 👀
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since v1, it's not possible to have custom content/components on the home page:
which was quite useful in v0.x to provide additional info on the home page.
This PR brings back the ability, but not so sure if it's a ideal solution