Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): support hiding aside component from frontmatter #980

Merged
merged 2 commits into from
Jul 14, 2022

Conversation

userquin
Copy link
Collaborator

@userquin userquin commented Jul 13, 2022

Sometime the space in the right sidebar is required, for example adding some app but we also need the left sidebar, since the sidebar is global we cannot remove the space on the right aside.

For example, in the vite-plugin-pwa we're adding an application and we want some more space (the right sidebar is there but with empty content):
https://streamable.com/3wjtca

Using the why VitePress in the docs here, the result is this (removed in this PR, just for testing purposes):
https://streamable.com/5uklw5

@userquin
Copy link
Collaborator Author

userquin commented Jul 13, 2022

In fact, we can use it to remove the right sidebar if we can detect the current page has no entries to be displayed.
Of course, we also need to check if the ads are configured.

EDIT: for example, this page in Vitest docs https://vitest.dev/guide/ui.html

@brc-dd brc-dd changed the title feat: add hide right sidebar configuration option feat(theme): support hiding aside component from frontmatter Jul 14, 2022
@brc-dd brc-dd merged commit 69ef299 into vuejs:main Jul 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants