Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase Node memory limit to workaround webpack crash, fix #1453 #1670

Closed
wants to merge 1 commit into from

Conversation

octref
Copy link
Member

@octref octref commented Jun 25, 2018

#1453 (comment)

@yyx990803 I've been running with this setting for a while and haven't encountered crashes any more.

@octref
Copy link
Member Author

octref commented Jun 25, 2018

Well, the builds are failing probably because this hits the memory limit on CircleCI: https://circleci.com/docs/1.0/oom. Wondering what should we do here...

@LinusBorg LinusBorg requested a review from yyx990803 July 2, 2018 11:16
@octref
Copy link
Member Author

octref commented Jul 4, 2018

The root cause seems to be webpack/webpack#6929.
I've been running this for a while, this lessens the issue but doesn't completely work around it. In 10-20 minutes of heavy editing I still get OOM error.

@DRoet
Copy link
Contributor

DRoet commented Jul 5, 2018

@yyx990803 @octref the memory leaks found in webpack/webpack#6929 have been resolved in
https://github.com/webpack/webpack/releases/tag/v4.15.1

which might resolve the issues in #1453

@octref
Copy link
Member Author

octref commented Jul 5, 2018

@DRoet Gave it a try, didn't help. webpack/webpack#6929 (comment)

@DRoet
Copy link
Contributor

DRoet commented Jul 10, 2018

@octref a fix for another memory leak landed in:
https://github.com/postcss/postcss-loader/releases/tag/v2.1.6

I'll try and test it out later

@octref
Copy link
Member Author

octref commented Jul 12, 2018

I'll open a new PR.

@octref octref closed this Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants