Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): add missing dependencies and require.resolve compiler #6456

Merged
merged 3 commits into from
May 7, 2021

Conversation

merceyz
Copy link
Contributor

@merceyz merceyz commented May 6, 2021

  • The typescript plugin depends on vue-template-compiler when using Vue 2 but it isn't declared
  • @babel/core isn't provided to babel-loader
  • The compiler passed to fork-ts-checker-webpack-plugin isn't resolved making it rely on hoisting

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@haoqunjiang haoqunjiang merged commit 2b3567c into vuejs:dev May 7, 2021
@merceyz merceyz deleted the merceyz/typescript-deps branch May 7, 2021 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants