feat(scroll) - WIP - allow a different scroll element other than window #2780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First time I am using Flow - so probably did some stuff wrong, let me know if you see anything obvious. If this is fine - I will proceed with fixing flow and creating new tests. |
|
Thanks for working on this I will come back to you when I can to review the api, this is the kind of thing that would nicely fit an RFC :) |
|
Any news? |
|
Hello! I just need this functionality. |
|
@posva, can we expect this pull request to be brought into life and reconsidered? Very, very useful feature I cannot find a workaround to at the moment :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a WIP - just to make sure I am on the right track before fixing flow / e2e / unit tests.
This works (for me locally), let me know what you think.
Fixes #2777