Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(runtime-vapor): simplify directive mechanism #278

Merged
merged 6 commits into from
Nov 13, 2024

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Sep 19, 2024

Simplify custom directive API to match the template ref API.

Waiting a formal RFC Internal API currently.

Closes #285

Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit 77c648f
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/6733f52e7c170100088d87e0
😎 Deploy Preview https://deploy-preview-278--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit 77c648f
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/6733f52e2494cf000840d952
😎 Deploy Preview https://deploy-preview-278--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Sep 19, 2024

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 81.9 kB 28.5 kB 25.1 kB
runtime-dom.global.prod.js 100 kB 38 kB 34.2 kB
runtime-vapor.global.prod.js 47.1 kB (+1.51 kB) 17.8 kB (+696 B) 16.3 kB (+622 B)
vue-vapor.global.prod.js 106 kB (+1.51 kB) 37.2 kB (+692 B) 33.4 kB (+545 B)
vue.global.prod.js 159 kB 57.9 kB 51.5 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.2 kB 18.4 kB 16.8 kB
createApp 55.2 kB 21.3 kB 19.5 kB
createSSRApp 59.2 kB 23 kB 21 kB
defineCustomElement 60 kB 22.9 kB 20.9 kB
vapor 47.5 kB (+1.51 kB) 18 kB (+692 B) 16.4 kB (+616 B)
overall 68.9 kB 26.4 kB 24 kB

@LittleSound
Copy link
Member

Great. I had this idea before. Thanks for starting it

can you explain how this API behaves differently from before?

@sxzz sxzz marked this pull request as draft September 21, 2024 18:33
Copy link

pkg-pr-new bot commented Sep 22, 2024

Open in Stackblitzplayground

@vue/compiler-core

pnpm add https://pkg.pr.new/vuejs/vue-vapor/@vue/compiler-core@278

@vue/compiler-dom

pnpm add https://pkg.pr.new/vuejs/vue-vapor/@vue/compiler-dom@278

@vue/compiler-ssr

pnpm add https://pkg.pr.new/vuejs/vue-vapor/@vue/compiler-ssr@278

@vue/compiler-sfc

pnpm add https://pkg.pr.new/vuejs/vue-vapor/@vue/compiler-sfc@278

@vue/compiler-vapor

pnpm add https://pkg.pr.new/vuejs/vue-vapor/@vue/compiler-vapor@278

@vue/reactivity

pnpm add https://pkg.pr.new/vuejs/vue-vapor/@vue/reactivity@278

@vue/runtime-core

pnpm add https://pkg.pr.new/vuejs/vue-vapor/@vue/runtime-core@278

@vue/runtime-dom

pnpm add https://pkg.pr.new/vuejs/vue-vapor/@vue/runtime-dom@278

@vue/runtime-shared

pnpm add https://pkg.pr.new/vuejs/vue-vapor/@vue/runtime-shared@278

@vue/runtime-vapor

pnpm add https://pkg.pr.new/vuejs/vue-vapor/@vue/runtime-vapor@278

@vue/server-renderer

pnpm add https://pkg.pr.new/vuejs/vue-vapor/@vue/server-renderer@278

@vue/shared

pnpm add https://pkg.pr.new/vuejs/vue-vapor/@vue/shared@278

vue

pnpm add https://pkg.pr.new/vuejs/vue-vapor/vue@278

@vue/compat

pnpm add https://pkg.pr.new/vuejs/vue-vapor/@vue/compat@278

@vue/vapor

pnpm add https://pkg.pr.new/vuejs/vue-vapor/@vue/vapor@278

commit: 77c648f

@sxzz sxzz mentioned this pull request Oct 23, 2024
@sxzz sxzz marked this pull request as ready for review November 13, 2024 00:29
@sxzz sxzz changed the title feat: custom directive v2 feat(runtime-vapor): simplify directive mechanism Nov 13, 2024
@sxzz sxzz changed the title feat(runtime-vapor): simplify directive mechanism refactor(runtime-vapor): simplify directive mechanism Nov 13, 2024
@sxzz sxzz merged commit c574faa into main Nov 13, 2024
11 checks passed
@sxzz sxzz deleted the feat/custom-directive-v2 branch November 13, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demo is broken
2 participants