-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(runtime-vapor): simplify directive mechanism #278
Merged
+153
−156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vapor-template-explorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for vapor-repl ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size ReportBundles
Usages
|
Great. I had this idea before. Thanks for starting it can you explain how this API behaves differently from before? |
sxzz
force-pushed
the
feat/custom-directive-v2
branch
from
September 22, 2024 14:35
afb8839
to
ecb93b9
Compare
Open in Stackblitz • playground @vue/compiler-core
@vue/compiler-dom
@vue/compiler-ssr
@vue/compiler-sfc
@vue/compiler-vapor
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-shared
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
@vue/vapor
commit: |
Closed
sxzz
force-pushed
the
feat/custom-directive-v2
branch
from
November 13, 2024 00:29
0ad2d25
to
855e5f4
Compare
sxzz
changed the title
feat: custom directive v2
feat(runtime-vapor): simplify directive mechanism
Nov 13, 2024
sxzz
changed the title
feat(runtime-vapor): simplify directive mechanism
refactor(runtime-vapor): simplify directive mechanism
Nov 13, 2024
sxzz
force-pushed
the
feat/custom-directive-v2
branch
from
November 13, 2024 00:39
855e5f4
to
77c648f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify custom directive API to match the template ref API.
Waiting a formal RFCInternal API currently.Closes #285