Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(runtime-vapor): lifecycle beforeUpdate and updated hooks #89

Merged
merged 11 commits into from
Jan 12, 2024
Merged

feat(runtime-vapor): lifecycle beforeUpdate and updated hooks #89

merged 11 commits into from
Jan 12, 2024

Conversation

LittleSound
Copy link
Member

@LittleSound LittleSound commented Jan 7, 2024 •
edited
Loading

related: #31, #65, #19

@LittleSound LittleSound changed the title feat(runtime): lifecycle beforeUpdate and Updated hooks feat(runtime-vapor): lifecycle beforeUpdate and Updated hooks Jan 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2024 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.3 kB (+105 B) 34.3 kB (+36 B) 30.9 kB (+45 B)
runtime-vapor.global.prod.js 24.5 kB (+388 B) 9.32 kB (+156 B) 8.57 kB (+140 B)
vue-vapor.global.prod.js 60.4 kB (+394 B) 20.9 kB (+157 B) 18.9 kB (+156 B)
vue.global.prod.js 147 kB (+105 B) 53.6 kB (+30 B) 47.8 kB (-7 B)

Usages

Name Size Gzip Brotli
createApp 50.8 kB (+105 B) 19.8 kB (+36 B) 18.1 kB (+36 B)
createSSRApp 54.1 kB (+105 B) 21.2 kB (+35 B) 19.3 kB (+50 B)
defineCustomElement 53 kB (+105 B) 20.6 kB (+38 B) 18.8 kB (+33 B)
vapor 24.5 kB (+388 B) 9.36 kB (+162 B) 8.61 kB (+131 B)
overall 64.2 kB (+105 B) 24.7 kB (+33 B) 22.5 kB (+31 B)

@LittleSound LittleSound force-pushed the feat/vapor-lifecycle-before-update-and-updated branch from 4185fb5 to a2c9fbc Compare January 7, 2024 17:31
@ubugeeei ubugeeei mentioned this pull request Jan 8, 2024
Closed
12 tasks
@LittleSound
Copy link
Member Author

In order to implement lifecycle hooks, I added a Middleware option to baseWatch. If this PR is approved, I will synchronize the relevant commit to the baseWatch's PR vuejs/core#9927.

@LittleSound LittleSound marked this pull request as ready for review January 9, 2024 14:47
@LittleSound LittleSound mentioned this pull request Jan 10, 2024
Closed
@LittleSound LittleSound requested a review from sxzz January 10, 2024 13:34
@sxzz sxzz changed the title feat(runtime-vapor): lifecycle beforeUpdate and Updated hooks feat(runtime-vapor): lifecycle beforeUpdate and updated hooks Jan 10, 2024
@sxzz sxzz merged commit 2cce436 into main Jan 12, 2024
5 checks passed
@sxzz sxzz deleted the feat/vapor-lifecycle-before-update-and-updated branch January 12, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LittleSound @sxzz