Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vue DevTools recommendation only shows for Chrome, not Firefox #8634

Closed
digitarald opened this issue Aug 10, 2018 · 3 comments
Closed

Vue DevTools recommendation only shows for Chrome, not Firefox #8634

digitarald opened this issue Aug 10, 2018 · 3 comments
Labels
good first issue has PR improvement

Comments

@digitarald
Copy link

Version

2.5.17

Reproduction link

http://localhost:8080 (any local dev setup)

Steps to reproduce

  • Run any dev build
  • Open the page Firefox without vue devtools installed
  • Open devtools console

What is expected?

Devtools extension gets recommended

What is actually happening?

Recommendation only shows for Chrome, not in Firefox

Logic is in https://github.com/vuejs/vue/blob/master/src/platforms/web/runtime/index.js#L51

Twist is that isChrome is only used in this one code; so maybe it could be changed to hasCompatibleExtension and include a Firefox UA detection. Alternatively UA detection can be dropped, so the link is always shown and users can figure out that they might switch browsers to use the devtools.
@posva
Copy link
Member

posva commented Aug 11, 2018

I know we can show it for Firefox and Safari as well. @znck @Akryum is it possible to always display it once we have the remote devtools or does something else need to be changed?

AlexMaguey added a commit to AlexMaguey/vue that referenced this issue Aug 11, 2018
@AlexMaguey
fix(runtime): DevTools recommendation shows for all browsers
5a76565 
Closes vuejs#8634
@AlexMaguey AlexMaguey mentioned this issue Aug 11, 2018
Merged
13 tasks
@kotAPI
Copy link

kotAPI commented Oct 13, 2018

Can I take this up? :)

@posva posva added the has PR label Oct 17, 2018
yyx990803 pushed a commit that referenced this issue Dec 20, 2018
@yyx990803
fix(runtime): DevTools recommendation shows for all browsers (#8638)
22ad266 
Close #8634
@yyx990803
Copy link
Member

Closed via #8638

f2009 pushed a commit to f2009/vue that referenced this issue Jan 25, 2019
fix(runtime): DevTools recommendation shows for all browsers (vuejs#8638
cacbbed 
)

Close vuejs#8634
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue has PR improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@digitarald @yyx990803 @posva @kotAPI