Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vue.config.errorHandler called twice when I return a rejected Promise from a handler of a component event #9511

Closed
jfgodoy opened this issue Feb 17, 2019 · 2 comments · Fixed by #9526, mariazevedo88/hash-generator-js#6, tghelere/valorize-vidas#3, tghelere/DeliVuery#15 or tghelere/vue-tetris#1
Closed

Vue.config.errorHandler called twice when I return a rejected Promise from a handler of a component event #9511

jfgodoy opened this issue Feb 17, 2019 · 2 comments · Fixed by #9526, mariazevedo88/hash-generator-js#6, tghelere/valorize-vidas#3, tghelere/DeliVuery#15 or tghelere/vue-tetris#1
Labels
bug

Comments

@jfgodoy
Copy link

jfgodoy commented Feb 17, 2019

Version

2.6.6

Reproduction link

https://codepen.io/anon/pen/qgQYra?editors=1011

Steps to reproduce

The problem seems to happen when I handle an event emitted from a component and return a rejected promise. To see the problem in action, open the codepen link, click the button and you will see in the console two logs of the same error, which means the Vue.config.errorHandler was called twice.

What is expected?

I expect the errrorHandler called once.

What is actually happening?

the errorHandler function is called twice.
@posva posva added the bug label Feb 18, 2019
@shasharoman shasharoman mentioned this issue Feb 19, 2019
Merged
13 tasks
@marcus-hiles
Copy link

@jfgodoy try using the async keyword with the promise, and lets see if it works for you.
I have another alternative if it doesn't work though

@jfgodoy
Copy link
Author

jfgodoy commented Feb 19, 2019

hi @marcus-hiles, with async I have the same problem. Only a synchronous throw works

yyx990803 pushed a commit that referenced this issue Feb 21, 2019
@shasharoman @yyx990803
fix(#9511): avoid promise catch multiple times (#9526)
2f3020e 
* fix(#9511): avoid promise catch multiple times

* fix(#9511): add a test case for util/error/invokeWithErrorHandling

* fix(#9511): update test case for util/error/invokeWithErrorHandling
@snyk-bot snyk-bot mentioned this issue Aug 13, 2019
Open
This was referenced Aug 29, 2019
Open
Open
Open
Open
Closed
@snyk-bot snyk-bot mentioned this issue Sep 12, 2019
Open
@tt9133github tt9133github mentioned this issue Sep 18, 2019
Open
This was referenced Sep 22, 2019
Merged
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Oct 26, 2019
Open
@snyk-bot snyk-bot mentioned this issue Dec 5, 2019
Open
Lostlover pushed a commit to Lostlover/vue that referenced this issue Dec 10, 2019
@shasharoman @Lostlover
fix(vuejs#9511): avoid promise catch multiple times (vuejs#9526)
dbc9208 
* fix(vuejs#9511): avoid promise catch multiple times

* fix(vuejs#9511): add a test case for util/error/invokeWithErrorHandling

* fix(vuejs#9511): update test case for util/error/invokeWithErrorHandling
This was referenced Jan 20, 2020
Merged
Merged
Merged
Merged
Merged
@snyk-bot snyk-bot mentioned this issue Jan 22, 2020
Merged
This was referenced Feb 6, 2020
Open
Open
Merged
@tt9133github tt9133github mentioned this issue Feb 14, 2020
Open
This was referenced Feb 24, 2020
Closed
Closed
This was referenced Mar 4, 2020
Open
Merged
Open
This was referenced Apr 15, 2020
Open
Merged
This was referenced May 4, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
3 participants
@posva @jfgodoy @marcus-hiles