-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(transition): looking up context
of transition
#9668
Conversation
This pull request is also fixed #9364. |
The test-e2e failed, I thought it was a problem with CircleCI, so I ignored it. Today I found that the test case was not updated. But also found some other hidden dangers, this PR does not seem to be compatible with the previous version, suppose there is a component of my-transition, his template is <my-transition v-if="showing"></my-transition> When |
context
of transition
I disagree with that this change is not breaking things. But See this issue: #10227 |
Just found an example on the web while trying to understand how to use transition as the root element of my component. Vue 2.6.4: https://codepen.io/tahazsh/pen/mvKjbq I think the documentation should be improved on how to handle transition when they are on root element. If you agree, I can open a new issue and reference this PR. |
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch for v2.x (or to a previous version branch), not themaster
branchfix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
fixed #9628
Transition inside child component with v-if should be no enter-transition, it depend on appear attribute.