address comments

vuejs · Apr 14, 2018 · 7eb2563 · 7eb2563
1 parent 6de2efa
commit 7eb2563
Showing 1 changed file with 7 additions and 13 deletions.
diff --git a/lib/default-theme/NavLink.vue b/lib/default-theme/NavLink.vue
@@ -2,16 +2,14 @@
   <router-link
     class="router-link"
     :to="item.link"
-    v-if="!isExternal(item.link)">
-    {{ item.text }}
-  </router-link>
+    v-if="!isExternal(item.link)"
+  >{{ item.text }}</router-link>
   <a
     v-else
     :href="item.link"
     target="_blank"
-    class="router-link">
-    {{ item.text }}
-  </a>
+    class="router-link"
+  >{{ item.text }}</a>
 </template>
 
 <script>
@@ -22,12 +20,8 @@
         required: true
       }
     },
-    mixins: [
-      {
-        methods: {
-          isExternal
-        }
-      }
-    ]
+    methods: {
+      isExternal
+    }
   }
 </script>