Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Navbar Links #37

Closed
citruspi opened this issue Apr 15, 2018 · 1 comment
Closed

External Navbar Links #37

citruspi opened this issue Apr 15, 2018 · 1 comment

Comments

@citruspi
Copy link

citruspi commented Apr 15, 2018

In the Navbar Links section of the Default Theme Config documentation, there's an example including an external link:

module.exports = {
  themeConfig: {
    nav: [
      { text: 'Home', link: '/' },
      { text: 'Guide', link: '/guide/' },
      { text: 'External', link: 'https://google.com' },
    ]
  }
}

The external link ends up being a link to http://localhost:8080/https://google.com.

@ulivz
Copy link
Member

ulivz commented Apr 15, 2018

Thanks for reporting for that! this issue has been fixed at #13 and now it's in code review, just wait for some minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants