Sunsetting webpack-serve #1195
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,26 +1,31 @@ | ||
| 'use strict' | ||
|
|
||
| module.exports = async (sourceDir, cliOptions = {}, ctx) => { | ||
| const { server, host, port } = await prepareServer(sourceDir, cliOptions, ctx) | ||
| server.listen(port, host, err => { | ||
| if (err) { | ||
| console.log(err) | ||
| } | ||
| }) | ||
| } | ||
|
|
||
| module.exports.prepare = prepareServer | ||
|
|
||
| async function prepareServer (sourceDir, cliOptions = {}, context) { | ||
| const WebpackDevServer = require('webpack-dev-server') | ||
| const { path } = require('@vuepress/shared-utils') | ||
| const webpack = require('webpack') | ||
| const chokidar = require('chokidar') | ||
|
|
||
| const prepare = require('./prepare/index') | ||
| const { chalk, logger } = require('@vuepress/shared-utils') | ||
| const HeadPlugin = require('./webpack/HeadPlugin') | ||
| const DevLogPlugin = require('./webpack/DevLogPlugin') | ||
| const createClientConfig = require('./webpack/createClientConfig') | ||
| const { applyUserWebpackConfig } = require('./util/index') | ||
| const { frontmatterEmitter } = require('@vuepress/markdown-loader') | ||
|
|
||
| const ctx = context || await prepare(sourceDir, cliOptions, false /* isProd */) | ||
|
|
||
| // setup watchers to update options and dynamically generated files | ||
| const update = (reason) => { | ||
|
|
@@ -105,52 +110,52 @@ module.exports = async function dev (sourceDir, cliOptions = {}) { | |
| config = applyUserWebpackConfig(userConfig, config, false /* isServer */) | ||
| } | ||
|
|
||
| const serverConfig = Object.assign({ | ||
| disableHostCheck: true, | ||
| compress: true, | ||
|
There was a problem hiding this comment. ✅Used to bnable gzip compression for everything served. |
||
| clientLogLevel: 'error', | ||
| hot: true, | ||
|
There was a problem hiding this comment. ✅Enable webpack's Hot Module Replacement feature. |
||
| quiet: true, | ||
|
There was a problem hiding this comment.
❌This option shouldn't be set to |
||
| headers: { | ||
| 'access-control-allow-origin': '*' | ||
| }, | ||
|
There was a problem hiding this comment. ✅This option was set to enable CQRS. |
||
| publicPath: ctx.base, | ||
|
There was a problem hiding this comment. ✅ |
||
| watchOptions: { | ||
| ignored: /node_modules/ | ||
| }, | ||
|
There was a problem hiding this comment. ✅Excluded such a huge folder. |
||
| historyApiFallback: { | ||
| rewrites: [ | ||
| { from: /\.html$/, to: '/' } | ||
| ] | ||
| }, | ||
|
There was a problem hiding this comment. ✅Follow the past configuration. |
||
| overlay: false, | ||
|
There was a problem hiding this comment. ✅Do not need to show a full-screen overlay in the browser when there are compiler errors or warnings |
||
| host, | ||
|
|
||
| contentBase: path.resolve(sourceDir, '.vuepress/public'), | ||
| before (app, server) { | ||
| ctx.pluginAPI.options.beforeDevServer.syncApply(app, server) | ||
| }, | ||
| after (app, server) { | ||
| ctx.pluginAPI.options.afterDevServer.syncApply(app, server) | ||
| } | ||
| }, ctx.siteConfig.devServer || {}) | ||
|
|
||
| WebpackDevServer.addDevServerEntrypoints(config, serverConfig) | ||
|
|
||
| const compiler = webpack(config) | ||
| const server = new WebpackDevServer(compiler, serverConfig) | ||
|
There was a problem hiding this comment. ❌We should create a Node.js API for e.g. custom a command to export current VuePress site to a PDF. const { dev } = require('vuepresss')
module.exports = {
extendCli (cli) {
cli
.command('export [targetDir]', 'export current vuepress site to a PDF')
.action(async (dir = '.') => {
const { port, host, server } = await dev.prepare()
server.listen(port, host, err => {
if (err) {
console.log(err)
}
})
// do somthing, such as launch browser to export PDF.
await generatePDF()
server.close()
})
}
} |
||
|
|
||
| return { | ||
| server, | ||
| host, | ||
| port, | ||
|
There was a problem hiding this comment. ✅Express enable range request in development. so removing it will not break the fix of #555. |
||
| ctx | ||
| } | ||
| } | ||
|
|
||
| function resolveHost (host) { | ||
| const defaultHost = 'localhost' | ||
| host = host || defaultHost | ||
| const displayHost = host === defaultHost | ||
| ? 'localhost' | ||
| : host | ||
| return { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| module.exports = require('@vuepress/core') |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅Used to bypasses host checking.