Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test #1561

Closed
wants to merge 2 commits into from
Closed

test #1561

wants to merge 2 commits into from

Conversation

zhanglan35
Copy link

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@zhanglan35 zhanglan35 marked this pull request as ready for review April 25, 2019 08:11
@ulivz
Copy link
Member

ulivz commented Apr 26, 2019

What problems does this PR solve?

@ulivz ulivz closed this Apr 26, 2019
@timaschew
Copy link
Contributor

@ulivz Seriously?
I've sent a PR 2 weeks ago: #1540 I haven't received any feedback yet but I was fixing the same issue with almost the same code. But this PR (with a ridiculous title) was merged.

👎

@ulivz
Copy link
Member

ulivz commented Apr 28, 2019

Merged? 🙂

@ulivz
Copy link
Member

ulivz commented Apr 28, 2019

If you don't want to cooperate happily, please don't speak here.

@timaschew
Copy link
Contributor

Oh, it was closed. Not merged. Got it, sorry ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants