Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme-default): use router for Algolia search #1706

Merged
merged 1 commit into from
Jul 20, 2019
Merged

feat(theme-default): use router for Algolia search #1706

merged 1 commit into from
Jul 20, 2019

Conversation

kidonng
Copy link
Contributor

@kidonng kidonng commented Jul 17, 2019

Summary

Use router.push for Algolia search suggestion links to provide a better experience (no refresh).

DocSearch Doc

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@ulivz ulivz merged commit 644142b into vuejs:master Jul 20, 2019
@vue-bot
Copy link

vue-bot commented Jul 20, 2019

Hey @kidonng, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

@kidonng kidonng mentioned this pull request Aug 15, 2019
18 tasks
sarahdayan pushed a commit that referenced this pull request Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants