-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix($shared-utils): improve title inference and header extraction for markdown links syntax #2688
Conversation
Please at least provide summary or the issue you were facing |
The following title cannot be resolved properly ### [Subscript](https://github.com/markdown-it/markdown-it-sub) / [Superscript](https://github.com/markdown-it/markdown-it-sup)
### [\<ins>](https://github.com/markdown-it/markdown-it-ins)
### [\<mark>](https://github.com/markdown-it/markdown-it-mark) It was wrongly parsed as <span>Subscript](https://github.com/markdown-it/markdown-it-sub) / [Superscript</span>
<span>\</span>
<span>\</span> The correct analysis should be <span>Subscript / Superscript</span>
<span><ins></span>
<span><mark></span> Sample snippet from: https://markdown-it.github.io/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nuochong!
There're unit tests for both files, could you update test cases?
fix: update test cases (vuejs#238)
sure |
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
before
after
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: