Change the required node version #321
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was getting this error:
>$ node bin/vuepress dev docs
SyntaxError: Invalid regular expression: /(?<=(^|\/))(index|readme)\.md$/: Invalid group
at Object.<anonymous> (/data/proyectos/blog/vuepress/lib/prepare.js:239:17)
The problem is that [**RegExp lookbehind** was implemented in V8 in version v6.2.103][look-behind-v8] and it [was just merged into the node engine in version 8.10][look-behind-node].
Check [this forum][forum] for more information.
[look-behind-v8]: https://chromium.googlesource.com/v8/v8.git/+/473a6f5b03651fde33fd7b3228a7dc4e38e24914
[look-behind-node]: https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V8.md#8.10.0
[forum]: https://groups.google.com/forum/#!msg/v8-users/r-SN2yuKTL8/pfwrSuqSBQAJ
|
Oh thanks, I didn't notice that. I added this in PR #308. I fact, there are other implementations to fix that bug, but |
|
@ulivz Better to change the node version or change the regex? |
|
@meteorlxy Just in case, I created an alternative PR to avoid lookbehind: #323 |
|
Thanks! I think that changing regexp would be a better choice. Closing as this has been done in #323 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting this error:
The problem is that RegExp lookbehind was implemented in V8 in version v6.2.103 and it was just merged into the node engine in version 8.10.
Check this forum for more information.