Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shiki/prismjs class names to differentiate highlight plugins #181

Merged
merged 2 commits into from
May 30, 2024

Conversation

pengzhanbo
Copy link
Member

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Provide a description in this PR that addresses what the PR is solving. If this PR is going to solve an existing issue, please reference the issue (e.g. close #123).

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other

Description

Screenshots

Before

After

@coveralls
Copy link

coveralls commented May 29, 2024

Pull Request Test Coverage Report for Build 9301432327

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 56.737%

Totals Coverage Status
Change from base Build 9286705501: -0.02%
Covered Lines: 1003
Relevant Lines: 1583

💛 - Coveralls

@pengzhanbo pengzhanbo changed the title feat: add shiki/prismjs class names to distinguish highlight library feat: add shiki/prismjs class names to differentiate highlight plugins May 29, 2024
@Mister-Hope
Copy link
Member

Mister-Hope commented May 30, 2024

Since there is already a shiki class on the pre element, I am thinking whether we could add a data-highlighter="shiki|prismjs" instead? This is unified with data-title and data-ext, and avoid the inconstant behavior that shiki is affecting wrapper and pre while prismjs only affects pre.

@Mister-Hope
Copy link
Member

@pengzhanbo need help here, I try to make some tweaks, but some code blocks are having extra line-numbers-mode

@Mister-Hope
Copy link
Member

Oh, that should be a bug you introduced in the first commit

image

image

@Mister-Hope Mister-Hope merged commit 0ef4c98 into main May 30, 2024
31 checks passed
@Mister-Hope Mister-Hope deleted the highlight-type branch May 30, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants