feat(theme-default): improve sidebar headers #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9380781281Details
💛 - Coveralls |
Mister-Hope
reviewed
Jun 5, 2024
|
|
||
| defineSlots<{ | ||
| 'top'?: (props: Record<never, never>) => any | ||
| 'bottom'?: (props: Record<never, never>) => any | ||
| 'content-top'?: (props: Record<never, never>) => any | ||
| 'content-bottom'?: (props: Record<never, never>) => any | ||
| }>() | ||
|
|
||
| setupHeaders() |
There was a problem hiding this comment.
The new headers need to wait for the <Content /> component to be Mounted before being read from the DOM. The <VPPage /> component can ensure that the DOM is Mounted, but placing it in the <Sidebar /> cannot guarantee this. Additionally, reading and generating new content to be inserted into the DOM after being Mounted may trigger onMounted again, causing unnecessary repeated calls and potentially leading to new issues.
Mister-Hope
reviewed
Jun 5, 2024
Mister-Hope
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
close #123).What is the purpose of this pull request?
Description