Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

fix: error when requiring dayjs #94

Merged
merged 1 commit into from
Jan 16, 2021
Merged

Conversation

billyyyyy3320
Copy link
Member

@billyyyyy3320 billyyyyy3320 commented Jan 16, 2021

Summary

Fix vuepress/vuepress-theme-blog#114

When version of dayjs is around v1.8.4, there would be an error during requiring dayjs.

Root cause:
webpack/webpack#4742
iamkun/dayjs#480
iamkun/dayjs#492

Changes:
Bump dayjs to the latest version

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@billyyyyy3320 billyyyyy3320 changed the title fix: error requiring dayjs (fix #114) fix: error when requiring dayjs (fix #114) Jan 16, 2021
@billyyyyy3320 billyyyyy3320 changed the title fix: error when requiring dayjs (fix #114) fix: error when requiring dayjs Jan 16, 2021
@billyyyyy3320 billyyyyy3320 merged commit 053a738 into master Jan 16, 2021
@billyyyyy3320 billyyyyy3320 deleted the fix/dayjs-no-default branch January 16, 2021 19:37
billyyyyy3320 added a commit that referenced this pull request Jan 16, 2021
@billyyyyy3320 billyyyyy3320 mentioned this pull request Jan 16, 2021
18 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: dayjs is not a function
1 participant