Add Prometheus resource usage metrics for middleware #7215
Conversation
🦋 Changeset detectedLatest commit: 30aa02e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sethidden
changed the title
| @@ -82,6 +83,8 @@ async function createServer< | |||
| res.end("ok"); | |||
| }); | |||
|
|
|||
| app.get("/metrics", createPrometheusMetricsHandler()); | |||
There was a problem hiding this comment.
It's not acceptable to expose this on the same port as the rest of the regular services. This should be a separate express app listening on another port.
| @@ -82,6 +83,8 @@ async function createServer< | |||
| res.end("ok"); | |||
| }); | |||
|
|
|||
| app.get("/metrics", createPrometheusMetricsHandler()); | |||
There was a problem hiding this comment.
Can be determined based on NODE_ENV
| * Express API handler that should be registered on the /metrics route | ||
| * so that Prometheus can periodically call the middleware's /metrics endpoint | ||
| * and scrape the metrics |
There was a problem hiding this comment.
What kind of metrics? This endpoint will be open (no token or whatever), anyone can hit it. Is it safe to expose such data?
There was a problem hiding this comment.
this will be a separate express instance hosted on another port. in our cloud only port 4000 is exposed, but if metrics will be in port e.g. 9090 it won't be passed through to the internet, and we only be available locally
|
Stale |
Sending a GET to /metrics will now output Prometheus metrics implemented by https://github.com/siimon/prom-client/
https://prometheus.io/docs/instrumenting/writing_clientlibs/#standard-and-runtime-collectors