Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task(helpers): Abstract helpers and remove duplicates #226

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

task(helpers): Abstract helpers and remove duplicates #226

wants to merge 15 commits into from

Conversation

ElijahKotyluk
Copy link
Contributor

No description provided.

@ElijahKotyluk
refactor(helpers): remove repetetive update file helper function
809cfba 
Replace with utils package update file function.
@ElijahKotyluk ElijahKotyluk linked an issue Dec 14, 2020 that may be closed by this pull request
[Task] abstract shared functionality into shared utils #224
Open
@ElijahKotyluk ElijahKotyluk added the enhancement New feature or request label Dec 14, 2020
@ElijahKotyluk ElijahKotyluk self-assigned this Dec 14, 2020
johnleider
johnleider requested changes Dec 18, 2020
View reviewed changes
packages/@vuetify/cli-plugin-utils/index.js Show resolved Hide resolved
packages/@vuetify/cli-plugin-utils/index.js Outdated
config = callback(require(rcPath));
} else if (fileExists(api, pkgPath)) {
configPath = pkgPath;
config = JSON.parse(fs.readFileSync(pkgPath, { encoding: "utf8" }));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it would be reused a lot, maybe can go into utils?

packages/vue-cli-plugin-vuetify/generator/tools/fonts.js Show resolved Hide resolved
packages/vue-cli-plugin-vuetify/generator/tools/polyfill.js Outdated Show resolved Hide resolved
packages/vue-cli-plugin-vuetify/generator/tools/polyfill.js Show resolved Hide resolved
packages/vue-cli-plugin-vuetify/generator/tools/vuetify.js Outdated Show resolved Hide resolved
packages/vue-cli-plugin-vuetify/generator/tools/vuetify.js Show resolved Hide resolved
ElijahKotyluk and others added 9 commits December 18, 2020 14:29
@ElijahKotyluk @johnleider
Update packages/@vuetify/cli-plugin-utils/index.js
75574ae 
Co-authored-by: John Leider <[email protected]>
@ElijahKotyluk @johnleider
Update packages/vue-cli-plugin-vuetify/generator/tools/fonts.js
37291a1 
Co-authored-by: John Leider <[email protected]>
@ElijahKotyluk @johnleider
Update packages/vue-cli-plugin-vuetify/generator/tools/polyfill.js
4f29944 
Co-authored-by: John Leider <[email protected]>
@ElijahKotyluk @johnleider
Update packages/vue-cli-plugin-vuetify/generator/tools/polyfill.js
27851bd 
Co-authored-by: John Leider <[email protected]>
@ElijahKotyluk @johnleider
Update packages/vue-cli-plugin-vuetify/generator/tools/vuetify.js
78c7759 
Co-authored-by: John Leider <[email protected]>
@ElijahKotyluk @johnleider
Update packages/vue-cli-plugin-vuetify/generator/tools/vuetify.js
be101a8 
Co-authored-by: John Leider <[email protected]>
@ElijahKotyluk
improvement(plugin-utils): add parseFile util function
11553e0
@ElijahKotyluk
refactor(plugin-utils): parsefile: add description comment
a70d4e9
@ElijahKotyluk
chore(merge): into local
0f5933d
@ElijahKotyluk
Copy link
Contributor Author

@johnleider when you have some time can you give this another look over?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnleider johnleider Awaiting requested review from johnleider

Assignees

@ElijahKotyluk ElijahKotyluk

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] abstract shared functionality into shared utils
2 participants
@ElijahKotyluk @johnleider