-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(groups): use suspense to delay rendering of group items #15215
Open
KaelWD
wants to merge
11
commits into
dev
Choose a base branch
from
fix/15207-suspense-groups
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+168
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
johnleider
force-pushed
the
next
branch
2 times, most recently
from
June 24, 2022 16:47
c62375c
to
c692f92
Compare
johnleider
added
T: bug
Functionality that does not work as intended/expected
E: group
Group composable
labels
Aug 9, 2022
MajesticPotatoe
force-pushed
the
next
branch
from
November 15, 2022 00:44
50e76f2
to
1057e25
Compare
johnleider
force-pushed
the
next
branch
3 times, most recently
from
November 29, 2022 23:53
b6aed82
to
ceaffe5
Compare
KaelWD
force-pushed
the
master
branch
3 times, most recently
from
April 13, 2023 11:01
aa22a14
to
ca89962
Compare
KaelWD
force-pushed
the
master
branch
4 times, most recently
from
May 21, 2023 08:15
ed1cacf
to
74cb462
Compare
MajesticPotatoe
force-pushed
the
master
branch
3 times, most recently
from
October 12, 2023 13:13
7ce7b02
to
1adfeaa
Compare
MajesticPotatoe
force-pushed
the
master
branch
2 times, most recently
from
October 20, 2023 01:52
bb07313
to
e5c1c07
Compare
Merged
3 tasks
johnleider
force-pushed
the
master
branch
8 times, most recently
from
December 17, 2023 01:32
7cd11a6
to
d0765f1
Compare
johnleider
force-pushed
the
master
branch
2 times, most recently
from
December 28, 2023 22:41
f931c2e
to
748056c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15207
Probably need the same for #15202 - collect all the items before rendering anything
An alternative would be to keep values instead of ids, and do a deepEqual on demand like in v2. That wouldn't help with #15202 though because layout items all depend on each other.