Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(groups): use suspense to delay rendering of group items #15215

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

KaelWD
Copy link
Member

@KaelWD KaelWD commented Jun 7, 2022

fixes #15207

Probably need the same for #15202 - collect all the items before rendering anything

An alternative would be to keep values instead of ids, and do a deepEqual on demand like in v2. That wouldn't help with #15202 though because layout items all depend on each other.

<template>
  <v-app>
    <v-container>
      <v-card>
        <v-btn-toggle v-model="selected" multiple variant="outlined">
          <v-btn v-for="server in items" :key="server">
            Server {{ server }}
          </v-btn>
        </v-btn-toggle>
        <br>
        You select: {{ selected }}
      </v-card>

      <v-card>
        <v-tabs>
          <v-tab>One</v-tab>
          <v-tab>Two</v-tab>
          <v-tab>Three</v-tab>
        </v-tabs>
      </v-card>

      <v-item-group>
        <v-item>
          <div>a</div>
          <div>b</div>
        </v-item>
      </v-item-group>

    </v-container>
  </v-app>
</template>

<script setup>
  import { computed, ref, watch } from 'vue'

  const items = [0, 1, 2]
  const selected = ref([...items])
</script>

@johnleider johnleider added T: bug Functionality that does not work as intended/expected E: group Group composable labels Aug 9, 2022
@KaelWD KaelWD changed the base branch from next to master February 5, 2023 14:27
@KaelWD KaelWD force-pushed the master branch 3 times, most recently from aa22a14 to ca89962 Compare April 13, 2023 11:01
@KaelWD KaelWD force-pushed the master branch 4 times, most recently from ed1cacf to 74cb462 Compare May 21, 2023 08:15
@KaelWD KaelWD added this to the v3.6.0 (Nebula) milestone Feb 8, 2024
@KaelWD KaelWD marked this pull request as ready for review February 8, 2024 03:47
@KaelWD KaelWD changed the base branch from master to dev February 8, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E: group Group composable T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.0.0] [V-Buttons-Toggle] Ref - Desync & Relative – Do Not Set Values
2 participants