-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VAutocomplete): divider/subheader not rendering #15728
Conversation
How about groups instead so they can be kept while filtering? type ListItem = ({
title?: string
subtitle?: string
avatar?: string
} | {
header: string
}) & {
divided?: boolean
children?: ListItem[]
}
const items = [
{
header: 'Group 1',
divided: true,
children: [
{
title: 'Trevor Hansen',
subtitle: 'Group 1',
},
],
},
] |
5466426
to
1be7299
Compare
|
d438115
to
fdd4a0a
Compare
fdd4a0a
to
f5e4b96
Compare
Hi, I agree with @KaelWD about real groups inside v-select/autocomplete, because the current implementation is not accessibility friendly. See the group ARIA role doc. |
+1 for merge |
50e76f2
to
1057e25
Compare
b6aed82
to
ceaffe5
Compare
The failed tests in this case are legitimate. |
7ce7b02
to
1adfeaa
Compare
bb07313
to
e5c1c07
Compare
7cd11a6
to
d0765f1
Compare
f931c2e
to
748056c
Compare
cd170f8
to
98e57dc
Compare
This is closed without a fix getting to master or am I just blind? |
Description
closes #15721
Motivation and Context
How Has This Been Tested?
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).