Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Epic 6: ics23 support #8

Closed
i-norden opened this issue Apr 19, 2021 · 2 comments · Fixed by cosmos/cosmos-sdk#10015
Closed

Epic 6: ics23 support #8

i-norden opened this issue Apr 19, 2021 · 2 comments · Fixed by cosmos/cosmos-sdk#10015

Comments

@i-norden
Copy link
Collaborator

i-norden commented Apr 19, 2021 •
edited
Loading

ics23 is a universal merkle proof format which we want to support with our SMT state commitment layer. We can either

  • Create a repo which wraps ics23 interface around the current LL-SMT proof method
  • Expose ics23 methods from within LL-SMT

We also need to update proof spec for SMT: see cosmos#8297 (comment)
@i-norden i-norden changed the title ics23 support Epic 5: ics23 support May 7, 2021
@roysc roysc mentioned this issue Aug 26, 2021
Merged
19 tasks
@i-norden i-norden changed the title Epic 5: ics23 support Epic 6: ics23 support Aug 28, 2021
@i-norden i-norden mentioned this issue Sep 8, 2021
Closed
@i-norden
Copy link
Collaborator Author

i-norden commented Sep 8, 2021

This was bundled into the new Epic 2

@i-norden
Copy link
Collaborator Author

Closing, see cosmos#9816 and child issues, tracking on zenhub

mergify bot pushed a commit to cosmos/cosmos-sdk that referenced this issue Feb 22, 2022
@roysc
feat: ADR-040: ICS-23 proofs for SMT store (#10015)
e66b8ef 
## Description

Implements [ICS-23](https://github.com/cosmos/ibc/tree/master/spec/core/ics-023-vector-commitments) conformant proofs for the SMT-based KV store and defines the proof spec as part of [ADR-040](https://github.com/cosmos/cosmos-sdk/blob/eb7d939f86c6cd7b4218492364cdda3f649f06b5/docs/architecture/adr-040-storage-and-smt-state-commitments.md). 

Closes: vulcanize#8

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - n/a
- [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [x] added a changelog entry to `CHANGELOG.md`
- [x] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: ADR-040: ICS-23 proofs for SMT store vulcanize/cosmos-sdk
1 participant
@i-norden