Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grub: T6453: Fixed GRUB variables parsing #3592

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

zdc
Copy link
Contributor

@zdc zdc commented Jun 6, 2024

Change Summary

Fixed GRUB variables parsing

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

GRUB

Proposed changes

To parse variables with = a variable name should be limited by alphanumerical characters only.

How to test

from vyos.system import grub
grub_vars = {
    'variable_name': 'variable=value',
}
grub.vars_write('/tmp/vars.test', grub_vars)
grub.vars_read('/tmp/vars.test')

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

To parse variables with `=` a variable name should be limited by alphanumerical
characters only.
@zdc zdc requested a review from a team as a code owner June 6, 2024 20:08
@dmbaturin dmbaturin merged commit a79c094 into vyos:current Jun 7, 2024
8 of 9 checks passed
@c-po
Copy link
Member

c-po commented Jun 9, 2024

@Mergifyio backport sagitta

Copy link
Contributor

mergify bot commented Jun 9, 2024

backport sagitta

✅ Backports have been created

c-po added a commit that referenced this pull request Jun 9, 2024
grub: T6453: Fixed GRUB variables parsing (backport #3592)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants