Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T5873: T6619: remove unused imports #3939

Merged
merged 2 commits into from
Aug 5, 2024
Merged

T5873: T6619: remove unused imports #3939

merged 2 commits into from
Aug 5, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Aug 4, 2024

Change Summary

Remove unused imports

# make unused-imports
************* Module protocols_static_multicast
src/conf_mode/protocols_static_multicast.py:17:0: W0611: Unused import os (unused-import)
src/conf_mode/protocols_static_multicast.py:25:0: W0611: Unused call imported from vyos.utils.process (unused-import)
src/conf_mode/protocols_static_multicast.py:26:0: W0611: Unused render imported from vyos.template (unused-import)
************* Module vpn_ipsec
src/conf_mode/vpn_ipsec.py:28:0: W0611: Unused Warning imported from vyos.base (unused-import)

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, -0.00)

make: *** [Makefile:108: unused-imports] Error 4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

  • multicast
  • vpn

Smoketest result

$  /usr/libexec/vyos/tests/smoke/cli/test_vpn_ipsec.py
test_dhcp_fail_handling (__main__.TestVPNIPsec.test_dhcp_fail_handling) ... ok
test_dmvpn (__main__.TestVPNIPsec.test_dmvpn) ... ok
test_flex_vpn_vips (__main__.TestVPNIPsec.test_flex_vpn_vips) ... ok
test_remote_access (__main__.TestVPNIPsec.test_remote_access) ... ok
test_remote_access_dhcp_fail_handling (__main__.TestVPNIPsec.test_remote_access_dhcp_fail_handling) ... ok
test_remote_access_eap_tls (__main__.TestVPNIPsec.test_remote_access_eap_tls) ... ok
test_remote_access_no_rekey (__main__.TestVPNIPsec.test_remote_access_no_rekey) ... ok
test_remote_access_pool_range (__main__.TestVPNIPsec.test_remote_access_pool_range) ... ok
test_remote_access_vti (__main__.TestVPNIPsec.test_remote_access_vti) ... ok
test_remote_access_x509 (__main__.TestVPNIPsec.test_remote_access_x509) ... ok
test_site_to_site (__main__.TestVPNIPsec.test_site_to_site) ... ok
test_site_to_site_vti (__main__.TestVPNIPsec.test_site_to_site_vti) ... ok
test_site_to_site_x509 (__main__.TestVPNIPsec.test_site_to_site_x509) ... ok

----------------------------------------------------------------------
Ran 13 tests in 65.442s

OK
$ /usr/libexec/vyos/tests/smoke/cli/test_protocols_static_multicast.py
test_01_static_multicast (__main__.TestProtocolsStaticMulticast.test_01_static_multicast) ... ok

----------------------------------------------------------------------
Ran 1 test in 4.514s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po c-po requested a review from a team as a code owner August 4, 2024 06:48
Copy link

github-actions bot commented Aug 4, 2024

👍
No issues in PR Title / Commit Title

Copy link

github-actions bot commented Aug 4, 2024


warning: Unused import os in src/conf_mode/protocols_static_multicast.py:17.warning: Unused call imported from vyos.utils.process in src/conf_mode/protocols_static_multicast.py:25.warning: Unused render imported from vyos.template in src/conf_mode/protocols_static_multicast.py:26.warning: Unused Warning imported from vyos.base in src/conf_mode/vpn_ipsec.py:28.

@c-po c-po enabled auto-merge August 4, 2024 14:16
@c-po c-po merged commit 9340765 into vyos:current Aug 5, 2024
13 of 15 checks passed
@c-po c-po mentioned this pull request Aug 5, 2024
12 tasks
@c-po c-po deleted the unused-imports branch August 5, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants