configd: T6640: enforce in_session returns False under configd #3955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CStore in_session check is a false positive outside of a config session if a specific environment variable is set with an existing referent in unionfs. To allow extensions when running under configd and avoid confusion, enforce in_session returns False.
jestabro
requested review from
dmbaturin,
sarthurdev,
zdc,
sever-sever,
c-po and
fett0
|
👍 |
This was referenced Aug 7, 2024
c-po
reviewed
Aug 7, 2024
c-po
approved these changes
Aug 8, 2024
sever-sever
approved these changes
Aug 8, 2024
dmbaturin
approved these changes
Aug 8, 2024
|
@Mergifyio backport circinus |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Injecting the environment variables needed for avoiding the use of my_set under configd (T6633) causes in_session to return True; we should enforce legacy checks to be consistent with the separation of concerns between the config session and conf_mode script execution.
For this (T6489/T6633) and other extensions as we move towards dropping CStore, in_session should return False if running under configd.
The complex of interactions is described in T6639.
Types of changes
Enforce distinction between configd and config session to allow extensions/alternatives to CStore.
Related Task(s)
Related PR(s)
Component(s) name
Proposed changes
How to test
Smoketest result
Checklist: