Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suricata: T6624: Make it possible for suricata address groups to reference each other #3958

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

natali-rs1985
Copy link
Contributor

@natali-rs1985 natali-rs1985 commented Aug 8, 2024

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

service suricata

Proposed changes

How to test

set service suricata interface 'eth1'
set service suricata port-group port-group port '5080'
set service suricata address-group home-net address '19.168.1.0/24'
set service suricata address-group home-net address '2001:8e0:3a60:b2c1::/64'
set service suricata address-group home-net address 'fd1a:dcb9:501c:1201::/64'
set service suricata address-group external-net group '!home-net'
commit

before the fix there was an error

vyos@vyos# commit

Invalid address-group: Undefined referenced group "home-net"

[[service suricata]] failed
Commit failed
[edit]

now it's working

vyos@vyos# commit
[ service suricata ]

WARNING: To fetch the latest rules, use "update suricata"; To
periodically fetch the latest rules, use the task scheduler!


[edit]

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Aug 8, 2024

👍
No issues in PR Title / Commit Title

@dmbaturin dmbaturin changed the title suricata: T6624: Fix for service suricata address-groups cannot be used in each other suricata: T6624: Make it possible for suricata address groups to reference each other Aug 9, 2024
Copy link

github-actions bot commented Aug 12, 2024

✅ No issues found in unused-imports check.. Please refer the workflow run

@c-po c-po merged commit e229d74 into vyos:current Aug 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants