Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6637: add pr commenting back in un-used import check #3965

Merged
merged 2 commits into from
Aug 11, 2024

Conversation

kumvijaya
Copy link
Contributor

@kumvijaya kumvijaya commented Aug 9, 2024

Change Summary

T6637: add pr commenting back in un-used import check.

Note
Added pr commenting back to un-used import check central workflow.
Caller workflows to use pull_request_target trigger now.
And checkout action in central workflow made to checkout head branch of the PR, so that pylint will scan only incoming changes.

Related .github PR needs to be merged

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/6637

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Aug 9, 2024


Commit title 'Merge branch 'current' into current' does not match the required format!. Valid title example: T99999: make IPsec secure

@c-po c-po enabled auto-merge August 10, 2024 14:26
@c-po c-po merged commit ba0f8db into vyos:current Aug 11, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants