Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6646: conntrack: in ignore rules, if protocols=all, do not append it to the rule #3981

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

nicolas-fort
Copy link
Contributor

Change Summary

in ignore rules, if protocols=all, do not append it to the rule

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

system conntrack

Proposed changes

How to test

vyos@upgr-test:~$ show config comm | grep ignore
set system conntrack ignore ipv4 rule 1 inbound-interface 'eth3'
set system conntrack ignore ipv4 rule 1 protocol 'all'
vyos@upgr-test:~$ sudo nft list chain ip vyos_conntrack VYOS_CT_IGNORE
table ip vyos_conntrack {
        chain VYOS_CT_IGNORE {
                iifname "eth3" counter packets 0 bytes 0 notrack comment "ignore-1"
                return
        }
}
vyos@upgr-test:~$ 

Smoketest result

test_system_conntrack.py --> OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

👍
No issues in PR Title / Commit Title

@dmbaturin dmbaturin merged commit 4806d87 into vyos:current Aug 14, 2024
13 of 14 checks passed
@dmbaturin
Copy link
Member

@Mergifyio backport circinus sagitta

Copy link
Contributor

mergify bot commented Aug 14, 2024

backport circinus sagitta

✅ Backports have been created

c-po added a commit that referenced this pull request Aug 14, 2024
T6646: conntrack: in ignore rules, if protocols=all, do not append it to the rule (backport #3981)
c-po added a commit that referenced this pull request Aug 15, 2024
T6646: conntrack: in ignore rules, if protocols=all, do not append it to the rule (backport #3981)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants