Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T6703: Adds option to configure AMD pstate driver #4046

Merged
merged 3 commits into from
Sep 12, 2024
Merged

T6703: Adds option to configure AMD pstate driver #4046

merged 3 commits into from
Sep 12, 2024

Conversation

nvollmar
Copy link
Contributor

@nvollmar nvollmar commented Sep 11, 2024 •
edited
Loading

Change Summary

Add system option to configure AMD pstate driver

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T6703

Related PR(s)

vyos/vyos-build#755
vyos/vyos-documentation#1543

Component(s) name

system

Proposed changes

Enable system command to set kernel boot args for configuring AMD pstate driver.

How to test

set system option kernel amd-pstate-driver passive

Smoketest result

None

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@nvollmar nvollmar requested a review from a team as a code owner September 11, 2024 10:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

👍
No issues in PR Title / Commit Title

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

✅ No issues found in unused-imports check.. Please refer the workflow run

@nvollmar nvollmar mentioned this pull request Sep 11, 2024
Merged
1 task
dmbaturin
dmbaturin requested changes Sep 11, 2024
View reviewed changes
Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It think help strings can be improved.

interface-definitions/system_option.xml.in Outdated Show resolved Hide resolved
interface-definitions/system_option.xml.in Outdated Show resolved Hide resolved
interface-definitions/system_option.xml.in Outdated Show resolved Hide resolved
@nvollmar
Copy link
Contributor Author

@dmbaturin I've updated/shortened the wording based on your proposals.

@c-po c-po merged commit 8f0a70c into vyos:current Sep 12, 2024
11 checks passed
@c-po
Copy link
Member

c-po commented Sep 12, 2024

@Mergifyio backport circinus

@mergify Mergify
Copy link

mergify bot commented Sep 12, 2024 •
edited
Loading

backport circinus

✅ Backports have been created

@mergify mergify bot mentioned this pull request Sep 12, 2024
Merged
12 tasks
@nvollmar nvollmar deleted the T6703 branch September 13, 2024 20:23
c-po added a commit that referenced this pull request Sep 15, 2024
@c-po
Merge pull request #4058 from vyos/mergify/bp/circinus/pr-4046
bc249af 
T6703: Adds option to configure AMD pstate driver (backport #4046)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmbaturin dmbaturin dmbaturin approved these changes

@c-po c-po c-po approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro is a code owner automatically assigned from vyos/reviewers

@fett0 fett0 Awaiting requested review from fett0 fett0 is a code owner automatically assigned from vyos/reviewers

Assignees

@nvollmar nvollmar

Labels
backport current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nvollmar @c-po @dmbaturin