Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6711: Fix restart vrrp missed comma between services #4054

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

sever-sever
Copy link
Member

Change Summary

Missing comma in the list between services
'ssh', 'suricata' 'vrrp', 'webproxy'
Fix it

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

restart

Proposed changes

How to test

Before the fix:

vyos@r14:~$ restart vrrp 
usage: restart.py restart_service [-h] [--raw] --name
                                  {dhcp,dhcpv6,dns_dynamic,dns_forwarding,igmp_proxy,ipsec,mdns_repeater,reverse_proxy,router_advert,snmp,ssh,suricatavrrp,webproxy} [--vrf VRF]
restart.py restart_service: error: argument --name: invalid choice: 'vrrp' (choose from 'dhcp', 'dhcpv6', 'dns_dynamic', 'dns_forwarding', 'igmp_proxy', 'ipsec', 'mdns_repeater', 'reverse_proxy', 'router_advert', 'snmp', 'ssh', 'suricatavrrp', 'webproxy')
vyos@r14:~$ 

After the fix:

vyos@r14:~$ restart vrrp 
Service vrrp is not configured!
vyos@r14:~$ 

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Missing comma in the list between services
 'ssh', 'suricata' 'vrrp', 'webproxy'
Fix it
Copy link

👍
No issues in PR Title / Commit Title

Copy link

✅ No issues found in unused-imports check.. Please refer the workflow run

@sever-sever
Copy link
Member Author

@Mergifyio backport circinus

Copy link
Contributor

mergify bot commented Sep 12, 2024

backport circinus

✅ Backports have been created

@dmbaturin dmbaturin merged commit 4339c09 into vyos:current Sep 12, 2024
14 of 16 checks passed
dmbaturin added a commit that referenced this pull request Sep 13, 2024
T6711: Fix restart vrrp missed comma between services (backport #4054)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants