Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

op-mode: T6715: manually changing time/date is not synced into hardware clock #4071

Merged
merged 1 commit into from
Sep 16, 2024
Merged

op-mode: T6715: manually changing time/date is not synced into hardware clock #4071

merged 1 commit into from
Sep 16, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Sep 15, 2024

Change Summary

When not using NTP and adjusting the current system time/date using set date the time is not saved across a reboot into the hardware RTC. This commit explicitly syncs the current time after a change into the systems RTC.

Most routers do not run without NTP (which is even a VyOS default) so the priority is pretty low.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

How to test

set date 0916140224

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po
op-mode: T6715: manually changing time/date is not synced into hardwa…
835126e 
…re clock

When not using NTP and adjusting the current system time/date using set date
the time is not saved across a reboot into the hardware RTC. This commit
explicitly syncs the current time after a change into the systems RTC.

Most routers do not run without NTP (which is even a VyOS default) so the
priority is pretty low.
@c-po c-po requested a review from a team as a code owner September 15, 2024 09:52
@c-po
Copy link
Member Author

c-po commented Sep 15, 2024

@Mergifyio backport sagitta circinus

@github-actions GitHub Actions
Copy link

👍
No issues in PR Title / Commit Title

@mergify Mergify
Copy link

mergify bot commented Sep 15, 2024 •
edited
Loading

backport sagitta circinus

✅ Backports have been created

@c-po c-po enabled auto-merge September 15, 2024 09:53
@c-po c-po merged commit 11164c8 into vyos:current Sep 16, 2024
15 of 16 checks passed
This was referenced Sep 16, 2024
Merged
Merged
dmbaturin added a commit that referenced this pull request Sep 16, 2024
@dmbaturin
Merge pull request #4075 from vyos/mergify/bp/circinus/pr-4071
4787549 
op-mode: T6715: manually changing time/date is not synced into hardware clock (backport #4071)
@c-po c-po deleted the date-time-T6715 branch September 16, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmbaturin dmbaturin dmbaturin approved these changes

@sever-sever sever-sever sever-sever approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro is a code owner automatically assigned from vyos/reviewers

@fett0 fett0 Awaiting requested review from fett0 fett0 is a code owner automatically assigned from vyos/reviewers

Assignees

@c-po c-po

Labels
backport current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c-po @dmbaturin @sever-sever