Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syslog: T6719: adds syslog local host name option #4079

Open
wants to merge 3 commits into
base: current
Choose a base branch
from

Conversation

nvollmar
Copy link
Contributor

@nvollmar nvollmar commented Sep 17, 2024

Change Summary

Add config option to set local host name for syslog

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

system

How to test

set system syslog global local-host-name vyos.example.local

Adds the rsyslog config entry

$LocalHostName vyos.example.local

Smoketest result

vyos@vyos:~$ /usr/libexec/vyos/tests/smoke/cli/test_system_syslog.py
test_syslog_basic (__main__.TestRSYSLOGService.test_syslog_basic) ... ok
test_syslog_global (__main__.TestRSYSLOGService.test_syslog_global) ... ok

----------------------------------------------------------------------
Ran 2 tests in 21.041s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Sep 17, 2024

👍
No issues in PR Title / Commit Title

@dmbaturin dmbaturin changed the title T6719: adds syslog local host name option syslog: T6719: adds syslog local host name option Sep 19, 2024
@dmbaturin dmbaturin enabled auto-merge (squash) September 19, 2024 16:33
interface-definitions/system_syslog.xml.in Outdated Show resolved Hide resolved
auto-merge was automatically disabled September 19, 2024 17:51

Head branch was pushed to by a user without write access

@nvollmar nvollmar requested a review from c-po September 20, 2024 11:38
interface-definitions/system_syslog.xml.in Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Sep 22, 2024

✅ No issues found in unused-imports check.. Please refer the workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants