Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6525: Add default dir for ext-scripts without absolute path (backport #3827) #4144

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 8, 2024

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

touch /config/user-data/test.sh
set service snmp script-extensions extension-name tst script test.sh 
commit

Smoketest result

vyos@vyos:~$ python3 /usr/libexec/vyos/tests/smoke/cli/test_service_snmp.py 
test_snmp_basic (__main__.TestSNMPService.test_snmp_basic) ... ok
test_snmp_script_extensions (__main__.TestSNMPService.test_snmp_script_extensions) ... ok
test_snmpv3_md5 (__main__.TestSNMPService.test_snmpv3_md5) ... 
service_snmp: ConfigError('Group membership required for user "vyos"!')


service_snmp: ConfigError('Must configure "view" for group "default_group"!')

ok
test_snmpv3_sha (__main__.TestSNMPService.test_snmpv3_sha) ... 
service_snmp: ConfigError('Must configure "view" for group "default"!')

ok
test_snmpv3_view_exclude (__main__.TestSNMPService.test_snmpv3_view_exclude) ... ok

----------------------------------------------------------------------
Ran 5 tests in 24.846s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

This is an automatic backport of pull request #3827 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner October 8, 2024 20:59
@mergify mergify bot requested review from dmbaturin, sarthurdev, zdc, jestabro, sever-sever and fett0 and removed request for a team October 8, 2024 20:59
Copy link

github-actions bot commented Oct 8, 2024

👍
No issues in PR Title / Commit Title

@sever-sever sever-sever merged commit bb2fa1d into circinus Oct 9, 2024
9 checks passed
@sever-sever sever-sever deleted the mergify/bp/circinus/pr-3827 branch October 17, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants