jool: T160: Added scripts to build jool package #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyosbot
requested review from
a team,
dmbaturin,
sarthurdev,
jestabro,
sever-sever and
c-po
and removed request for
a team
frebib
reviewed
May 1, 2023
frebib
reviewed
May 1, 2023
Added dependencies and build scripts for https://github.com/NICMx/Jool/
dmbaturin
approved these changes
May 1, 2023
| PACKAGE_VERSION: str = '4.1.9+bf4c7e3669' | ||
| PACKAGE_DIR: str = f'{PACKAGE_NAME}-{PACKAGE_VERSION}' | ||
| SOURCES_ARCHIVE: str = 'jool-4.1.9+bf4c7e3669.tar.gz' | ||
| SOURCES_URL: str = f'https://github.com/NICMx/Jool/archive/bf4c7e3669672367934dc50c8b257b7790f0e27e.tar.gz' |
There was a problem hiding this comment.
Is there a particular reason to use a commit tarball URL instead of a tag URL? Generally, a tag URL would look more obvious and easier to update.
There was a problem hiding this comment.
For the history. It cannot be built without this. This is the reason why a specific commit-id is required.
|
Just to note, Jool seems to be stuck only supporting iptables. Ref: NICMx/Jool#273 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Added scripts to build jool package
Types of changes
Related Task(s)
Component(s) name
jool
Proposed changes
Added dependencies and build scripts for https://github.com/NICMx/Jool/
How to test
Create a new Docker image and start Jenkins build for the linux-kernel package.
Checklist: