VPN documentation proofreading #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change Cerbort->Certbot Update first line to reflect that openconnect was introduced in 1.3-rolling (T2036)
c-po
requested changes
Jul 13, 2024
docs/configuration/vpn/ipsec.rst
Outdated
| the applications. | ||
| match the IPsec policy of a typical site-to-site setup and you would need to | ||
| add special configuration for it, or adjust the source address for your | ||
| applications' outgoing traffic. GRE/IPsec has no such problem and is completely |
There was a problem hiding this comment.
applications are plural, and it’s a possessive apostrophe
I can reword it to make it simpler if you’d prefer.
There was a problem hiding this comment.
Shouldn't it be application's then instead?
There was a problem hiding this comment.
The intended syntax here is possessive(plural('application')). In different words, "or adjust the source address for outgoing traffic of your applications". I might prefer the latter, but I have no objections against "applications' outgoing traffic".
There was a problem hiding this comment.
Your wording here is clearer. I’ll update the wording to match, thanks!
rephrase for clarity and to avoid possessive plural apostrophe
|
Thanks! |
c-po
pushed a commit
that referenced
this pull request
Jul 18, 2024
* Fix typos in openconnect.rst change Cerbort->Certbot Update first line to reflect that openconnect was introduced in 1.3-rolling (T2036) * typo in dmvpn.rst * ipsec.rst justification, minor phrasing changes * l2tp.rst justification and phrasing changes. * sstp.rst phrasing, justification changes * Update ipsec.rst rephrase for clarity and to avoid possessive plural apostrophe (cherry picked from commit 873a461)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
openconnect.rst: spelling errors corrected
dmvpn.rst: small spelling error corrected
ipsec.rst: updated justification, changes to phrasing
l2tp.rst: updated justification, changes to phrasing
sstp.rst: updated justification, changes to phrasing
Related Task(s)
N/A, documentation change.
Related PR(s)
Backport
Ideally back to at least 1.4, but likely applicable to 1.3 as well.
Checklist: