Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: chain_id as integer #158

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

DanielSchiavini
Copy link
Collaborator

What I did

Allowed chain_id to be passed as integer as that's what users are expecting.

How I did it

  • Encoding/decoding the hex string

How to verify it

  • boa.env.set_chain_id(1) should actually work

Description for the changelog

  • Allow integers to be passed to boa.env.set_chain_id`

Cute Animal Picture

image

@DanielSchiavini DanielSchiavini changed the title Allow chain_id as integer feat: chain_id as integer Feb 15, 2024
@charles-cooper charles-cooper merged commit 51da344 into vyperlang:master Feb 16, 2024
5 of 8 checks passed
@DanielSchiavini DanielSchiavini deleted the chain_id_int branch February 16, 2024 12:29
@DanielSchiavini DanielSchiavini self-assigned this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants